pgsql: Fix corner-case 64-bit integer subtraction bug on some platforms - Mailing list pgsql-committers

From Dean Rasheed
Subject pgsql: Fix corner-case 64-bit integer subtraction bug on some platforms
Date
Msg-id E1r11rU-004dYc-FI@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix corner-case 64-bit integer subtraction bug on some platforms.

When computing "0 - INT64_MIN", most platforms would report an
overflow error, which is correct. However, platforms without integer
overflow builtins or 128-bit integers would fail to spot the overflow,
and incorrectly return INT64_MIN.

Back-patch to all supported branches.

Patch be me. Thanks to Jian He for initial investigation, and Laurenz
Albe and Tom Lane for review.

Discussion: https://postgr.es/m/CAEZATCUNK-AZSD0jVdgkk0N%3DNcAXBWeAEX-QU9AnJPensikmdQ%40mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b17a02be27e01d46cf9a74d173009547305d4cf8

Modified Files
--------------
src/include/common/int.h           | 6 +++++-
src/test/regress/expected/int8.out | 2 ++
src/test/regress/sql/int8.sql      | 1 +
3 files changed, 8 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Fix uninitialized slot array access during the upgrade.
Next
From: David Rowley
Date:
Subject: pgsql: Ensure we use the correct spelling of "ensure"