pgsql: Be more wary about NULL values for GUC string variables. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Be more wary about NULL values for GUC string variables.
Date
Msg-id E1qya0r-003brQ-WC@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Be more wary about NULL values for GUC string variables.

get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN
has a NULL boot_val.  Nosing around found a couple of other places
that seemed insufficiently cautious about NULL string values, although
those are likely unreachable in practice.  Add some commentary
defining the expectations for NULL values of string variables,
in hopes of forestalling future additions of more such bugs.

Xing Guo, Aleksander Alekseev, Tom Lane

Discussion: https://postgr.es/m/CACpMh+AyDx5YUpPaAgzVwC1d8zfOL4JoD-uyFDnNSa1z0EsDQQ@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/65810fc6d0f6ccd3166713b9ec2f856be535383f

Modified Files
--------------
src/backend/utils/misc/guc.c   | 12 ++++++++++--
src/include/utils/guc_tables.h | 10 ++++++++++
2 files changed, 20 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Attempt to stabilize postgres_fdw tests
Next
From: David Rowley
Date:
Subject: pgsql: Stabilize postgres_fdw tests on 32-bit machines