pgsql: amcheck: Distinguish interrupted page deletion from corruption. - Mailing list pgsql-committers

From Noah Misch
Subject pgsql: amcheck: Distinguish interrupted page deletion from corruption.
Date
Msg-id E1qxa6G-003AIt-RY@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
amcheck: Distinguish interrupted page deletion from corruption.

This prevents false-positive reports about "the first child of leftmost
target page is not leftmost of its level", "block %u is not leftmost"
and "left link/right link pair".  They appeared if amcheck ran before
VACUUM cleaned things, after a cluster exited recovery between the
first-stage and second-stage WAL records of a deletion.  Back-patch to
v11 (all supported versions).

Reviewed by Peter Geoghegan.

Discussion: https://postgr.es/m/20231005025232.c7.nmisch@google.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f31ccb575ed6563b8490cb600ec083ef4b6634bf

Modified Files
--------------
contrib/amcheck/t/005_pitr.pl   | 88 +++++++++++++++++++++++++++++++++++++++++
contrib/amcheck/verify_nbtree.c | 79 +++++++++++++++++++++++++++++++++---
2 files changed, 162 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: pgindent run to fix commits de64268561 and 5ae2087202a
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Teach contrib/amcheck to check the unique constraint violation