pgsql: jit: Support opaque pointers in LLVM 16. - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: jit: Support opaque pointers in LLVM 16.
Date
Msg-id E1qt3sb-001983-Un@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
jit: Support opaque pointers in LLVM 16.

Remove use of LLVMGetElementType() and provide the type of all pointers
to LLVMBuildXXX() functions when emitting IR, as required by modern LLVM
versions[1].

 * For LLVM <= 14, we'll still use the old LLVMBuildXXX() functions.
 * For LLVM == 15, we'll continue to do the same, explicitly opting
   out of opaque pointer mode.
 * For LLVM >= 16, we'll use the new LLVMBuildXXX2() functions that take
   the extra type argument.

The difference is hidden behind some new IR emitting wrapper functions
l_load(), l_gep(), l_call() etc.  The change is mostly mechanical,
except that at each site the correct type had to be provided.

In some places we needed to do some extra work to get functions types,
including some new wrappers for C++ APIs that are not yet exposed by in
LLVM's C API, and some new "example" functions in llvmjit_types.c
because it's no longer possible to start from the function pointer type
and ask for the function type.

Back-patch to 12, because it's a little tricker in 11 and we agreed not
to put the latest LLVM support into the upcoming final release of 11.

[1] https://llvm.org/docs/OpaquePointers.html

Reviewed-by: Dmitry Dolgov <9erthalion6@gmail.com>
Reviewed-by: Ronan Dunklau <ronan.dunklau@aiven.io>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CA%2BhUKGKNX_%3Df%2B1C4r06WETKTq0G4Z_7q4L4Fxn5WWpMycDj9Fw%40mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f28956b239f19858e7c429d3065678ce79c5104b

Modified Files
--------------
src/backend/jit/llvm/llvmjit.c        | 130 ++++++-----
src/backend/jit/llvm/llvmjit_deform.c | 119 +++++-----
src/backend/jit/llvm/llvmjit_expr.c   | 400 ++++++++++++++++++++--------------
src/backend/jit/llvm/llvmjit_types.c  |  25 +++
src/backend/jit/llvm/llvmjit_wrap.cpp |  12 +
src/include/jit/llvmjit.h             |   7 +
src/include/jit/llvmjit_emit.h        | 106 ++++++---
7 files changed, 502 insertions(+), 297 deletions(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: jit: Support opaque pointers in LLVM 16.
Next
From: Thomas Munro
Date:
Subject: pgsql: jit: Support opaque pointers in LLVM 16.