pgsql: Fix bulk table extension when copying into multiple partitions - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Fix bulk table extension when copying into multiple partitions
Date
Msg-id E1qrUP7-000Rc9-21@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix bulk table extension when copying into multiple partitions

When COPYing into a partitioned table that does now permit the use of
table_multi_insert(), we could error out with
  ERROR: could not read block NN in file "base/...": read only 0 of 8192 bytes

because BulkInsertState->next_free was not reset between partitions. This
problem occurred only when not able to use table_multi_insert(), as a
dedicated BulkInsertState for each partition is used in that case.

The bug was introduced in 00d1e02be24, but it was hard to hit at that point,
as commonly bulk relation extension is not used when not using
table_multi_insert(). It became more likely after 82a4edabd27, which expanded
the use of bulk extension.

To fix the bug, reset the bulk relation extension state in BulkInsertState in
ReleaseBulkInsertStatePin(). That was added (in b1ecb9b3fcf) to tackle a very
similar issue.  Obviously the name is not quite correct, but there might be
external callers, and bulk insert state needs to be reset in precisely in the
situations that ReleaseBulkInsertStatePin() already needed to be called.

Medium term the better fix likely is to disallow reusing BulkInsertState
across relations.

Add a test that, without the fix, reproduces #18130 in most
configurations. The test also catches the problem fixed in b1ecb9b3fcf when
run with small shared_buffers.

Reported-by: Ivan Kolombet <enderstd@gmail.com>
Analyzed-by: Tom Lane <tgl@sss.pgh.pa.us>
Analyzed-by: Andres Freund <andres@anarazel.de>
Bug: #18130
Discussion: https://postgr.es/m/18130-7a86a7356a75209d%40postgresql.org
Discussion: https://postgr.es/m/257696.1695670946%40sss.pgh.pa.us
Backpatch: 16-

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/22655aa23132a0645fdcdce4b233a1fff0c0cf8f

Modified Files
--------------
src/backend/access/heap/heapam.c   | 11 +++++++++++
src/test/regress/expected/copy.out | 37 +++++++++++++++++++++++++++++++++++++
src/test/regress/sql/copy.sql      | 37 +++++++++++++++++++++++++++++++++++++
3 files changed, 85 insertions(+)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: Improve the naming in wal_sync_method code.
Next
From: Tom Lane
Date:
Subject: pgsql: Harden has_xxx_privilege() functions against concurrent object d