pgsql: Refactor ListenSocket array. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Refactor ListenSocket array.
Date
Msg-id E1qoN9e-0009uO-Qd@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Refactor ListenSocket array.

Keep track of the used size of the array. That avoids looping through
the whole array in a few places. It doesn't matter from a performance
point of view since the array is small anyway, but this feels less
surprising and is a little less code. Now that we have an explicit
NumListenSockets variable that is statically initialized to 0, we
don't need the loop to initialize the array.

Allocate the array in PostmasterContext. The array isn't needed in
child processes, so this allows reusing that memory. We could easily
make the array resizable now, but we haven't heard any complaints
about the current 64 sockets limit.

Discussion: https://www.postgresql.org/message-id/7bb7ad65-a018-2419-742f-fa5fd877d338@iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e29c46439511a2ba8b447079f2308384a4228c92

Modified Files
--------------
src/backend/libpq/pqcomm.c          | 20 ++++------
src/backend/postmaster/postmaster.c | 79 +++++++++++++++----------------------
src/include/libpq/libpq.h           |  2 +-
3 files changed, 40 insertions(+), 61 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Improve JsonLexContext's freeability
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Push attidentity and attgenerated handling into BuildDescForRela