pgsql: Modernize const handling with readline - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Modernize const handling with readline
Date
Msg-id E1qoIIW-0007Ml-6a@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Modernize const handling with readline

The comment

    /* On some platforms, readline is declared as readline(char *) */

is obsolete.  The casting away of const can be removed.

The const in the readline() prototype was added in GNU readline 4.2,
released in 2001.  BSD libedit has also had const in the prototype
since at least 2001.

(The commit that introduced this comment (187e865174) talked about
FreeBSD 4.8, which didn't have readline compatibility in libedit yet,
so it must have been talking about GNU readline in the base system.
This checks out, but already FreeBSD 5 had an updated GNU readline
with const.)

Reviewed-by: Aleksander Alekseev <aleksander@timescale.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/862fc1d4-9a0c-d2b6-5451-ee3dc750bcab%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8666cf65ea6926b6d8c781ae03891435131911cd

Modified Files
--------------
src/bin/psql/input.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: worker_spi: Expand set of options to start workers
Next
From: David Rowley
Date:
Subject: pgsql: Fix memory leak in Memoize code