pgsql: unaccent: Tweak value of PYTHON when building without Python sup - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: unaccent: Tweak value of PYTHON when building without Python sup
Date
Msg-id E1qlNJR-006DsJ-PD@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
unaccent: Tweak value of PYTHON when building without Python support

As coded, the module's Makefile would fail to set a value for PYTHON as
it checked if the variable is defined.  When compiling without
--with-python, PYTHON is defined and set to an empty value, so the
existing check is not able to do its work.

This commit switches the rule to check if the value is empty rather than
defined, allowing the generation of unaccent.rules even if --with-python
is not used as long as "python" exists.  BISON and FLEX do the same in
pgxs.mk, for instance.

Thinko in f85a485f89e2.

Author: Japin Li
Discussion: https://postgr.es/m/MEYP282MB1669F86C0DC7B4DC48489CB0B6C3A@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
Backpatch-through: 13

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/641db601b72fc501b10e02ce1a018d9d103d355c

Modified Files
--------------
contrib/unaccent/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Stop using "-multiply_defined suppress" on macOS.
Next
From: Amit Kapila
Date:
Subject: pgsql: Fix the misuse of origin filter across multiple pg_logical_slot_