pgsql: pg_dump: tests: Correct test condition for invalid databases - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: pg_dump: tests: Correct test condition for invalid databases
Date
Msg-id E1qkrbe-005vR3-L9@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_dump: tests: Correct test condition for invalid databases

For some reason I used not_like = { pg_dumpall_dbprivs => 1, } in the test
condition of one of the tests added in in c66a7d75e65. That doesn't make sense
for two reasons: 1) not_like isn't a valid test condition 2) the database
should not be dumped in any of the tests.  Due to 1), the test achieved its
goal, but clearly the formulation is confusing.  Instead use like => {}, with
a comment explaining why.

Reported-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://postgr.es/m/3ddf79f2-8b7b-a093-11d2-5c739bc64f86@eisentraut.org
Backpatch: 11-, like c66a7d75e65

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4dfb610822d5ab4bea7820da9be02d83bad69fb5

Modified Files
--------------
src/bin/pg_dump/t/002_pg_dump.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: pg_dump: tests: Correct test condition for invalid databases
Next
From: Nathan Bossart
Date:
Subject: pgsql: Add worker type to pg_stat_subscription.