pgsql: Fix assertion failure with PL/Python exceptions - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Fix assertion failure with PL/Python exceptions
Date
Msg-id E1qiNin-004e9g-Ut@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix assertion failure with PL/Python exceptions

PLy_elog() was not able to handle correctly cases where a SPI called
failed, which would fill in a DETAIL string able to trigger an
assertion.  We may want to improve this infrastructure so as it is able
to provide any extra detail information provided by an error stack, but
this is left as a future improvement as it could impact existing error
stacks and any applications that depend on them.  For now, the assertion
is removed and a regression test is added to cover the case of a failure
with a detail string.

This problem exists since 2bd78eb8d51c, so backpatch all the way down
with tweaks to the regression tests output added where required.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/18070-ab9c171cbf4ebb0f@postgresql.org
Backpatch-through: 11

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/af5b3c3d1eae94e9584ad1955a20b5a7cd0083c1

Modified Files
--------------
src/pl/plpython/expected/plpython_error.out   | 13 +++++++++++++
src/pl/plpython/expected/plpython_error_5.out | 13 +++++++++++++
src/pl/plpython/plpy_elog.c                   |  3 ---
src/pl/plpython/sql/plpython_error.sql        | 11 +++++++++++
4 files changed, 37 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: Add function for removing arbitrary nodes in binaryheap.
Next
From: Michael Paquier
Date:
Subject: pgsql: Improve error message for snapshot import in snapmgr.c, take two