pgsql: Don't crash if cursor_to_xmlschema is used on a non-data-returni - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Don't crash if cursor_to_xmlschema is used on a non-data-returni
Date
Msg-id E1qiIz3-004bfG-4C@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't crash if cursor_to_xmlschema is used on a non-data-returning Portal.

cursor_to_xmlschema() assumed that any Portal must have a tupDesc,
which is not so.  Add a defensive check.

It's plausible that this mistake occurred because of the rather
poorly chosen name of the lookup function SPI_cursor_find(),
which in such cases is returning something that isn't very much
like a cursor.  Add some documentation to try to forestall future
errors of the same ilk.

Report and patch by Boyu Yang (docs changes by me).  Back-patch
to all supported branches.

Discussion: https://postgr.es/m/dd343010-c637-434c-a8cb-418f53bda3b8.yangboyu.yby@alibaba-inc.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9baabfa38e005699fc21d76875f03cc2f204258c

Modified Files
--------------
doc/src/sgml/spi.sgml       | 13 +++++++++++++
src/backend/utils/adt/xml.c |  4 ++++
2 files changed, 17 insertions(+)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Fix psql's \? output for \watch
Next
From: Nathan Bossart
Date:
Subject: pgsql: Make binaryheap available to frontend code.