pgsql: Fix get_expr_result_type() to find field names for RECORD Consts - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix get_expr_result_type() to find field names for RECORD Consts
Date
Msg-id E1qhFx0-0042tj-J5@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix get_expr_result_type() to find field names for RECORD Consts.

This is a back-patch of commit d57534740 ("Fix EXPLAIN of SEARCH
BREADTH FIRST with a constant initial value") into pre-v14 branches.
At the time I'd thought it was not needed in branches that lack the
SEARCH/CYCLE feature, but that was just a failure of imagination.
It's possible to demonstrate "record type has not been registered"
failures in older branches too, during deparsing of views that contain
references to fields of composite constants.

Back-patch only the code changes, as the test cases added by d57534740
all require SEARCH/CYCLE syntax.  A suitable test case will be added
in the upcoming fix for bug #18077.

Discussion: https://postgr.es/m/17644-3bd1f3036d6d7a16@postgresql.org
Discussion: https://postgr.es/m/3607145.1694803130@sss.pgh.pa.us

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/59bc0dfe44a640c88adecc5b97def54b7355abcf

Modified Files
--------------
src/backend/utils/adt/ruleutils.c |  3 ++-
src/backend/utils/fmgr/funcapi.c  | 34 ++++++++++++++++++++++++++++++++++
2 files changed, 36 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: Rename variable for code clarity
Next
From: Tom Lane
Date:
Subject: pgsql: Fix get_expr_result_type() to find field names for RECORD Consts