pgsql: Refactor error messages for unsupported providers in pg_locale.c - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Refactor error messages for unsupported providers in pg_locale.c
Date
Msg-id E1qgZOg-003hA0-KN@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Refactor error messages for unsupported providers in pg_locale.c

These code paths should not be reached normally, but if they are an
error with "(null)" as information for the collation provider would show
up if no locale is set, while we can assume that we are referring to
libc.

This refactors the code so as the provider is always reported even if no
locale is set.  The name of the function where the error happens is
added, while on it, as it can be helpful for debugging.

Issue introduced by d87d548cd030, so backpatch down to 16.

Author: Michael Paquier, Ranier Vilela
Reviewed-by: Jeff Davis, Kyotaro Horiguchi
Discussion: https://postgr.es/m/7073610042fcf97e1bea2ce08b7e0214b5e11094.camel@j-davis.com
Backpatch-through: 16

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/800d5bcb982b096a71438f36b8b22a3b5b557aa9

Modified Files
--------------
src/backend/utils/adt/pg_locale.c | 34 +++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Fix incorrect logic in plan dependency recording
Next
From: Michael Paquier
Date:
Subject: pgsql: Improve error message on snapshot import in snapmgr.c