pgsql: Rename some support functions for pgstat* views. - Mailing list pgsql-committers

From Nathan Bossart
Subject pgsql: Rename some support functions for pgstat* views.
Date
Msg-id E1qbT3O-001jDb-SO@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Rename some support functions for pgstat* views.

Presently, pgstat_fetch_stat_beentry() accepts a session's backend
ID as its argument, and pgstat_fetch_stat_local_beentry() accepts a
1-based index in an internal array as its argument.  The former is
typically used wherever a user must provide a backend ID, and the
latter is usually used internally when looping over all entries in
the array.  This difference was first introduced by d7e39d72ca.
Before that commit, both functions accepted a 1-based index to the
internal array.

This commit renames these two functions to make it clear whether
they use the backend ID or the 1-based index to look up the entry.
This is preparatory work for a follow-up change that will introduce
a function for looking up a LocalPgBackendStatus using a backend
ID.

Reviewed-by: Ian Barwick, Sami Imseih, Michael Paquier, Robert Haas
Discussion: https://postgr.es/m/CAB8KJ%3Dj-ACb3H4L9a_b3ZG3iCYDW5aEu3WsPAzkm2S7JzS1Few%40mail.gmail.com
Backpatch-through: 16

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8dfa37b797843a83a5756ea3309055e8953e1a86

Modified Files
--------------
src/backend/utils/activity/backend_status.c | 28 +++++++++++-----------
src/backend/utils/adt/pgstatfuncs.c         | 36 ++++++++++++++---------------
src/include/utils/backend_status.h          |  4 ++--
3 files changed, 34 insertions(+), 34 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Fix possible compiler warning
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix some shadow variables in src/backend/replication/