pgsql: Avoid possible overflow with ltsGetFreeBlock() in logtape.c - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Avoid possible overflow with ltsGetFreeBlock() in logtape.c
Date
Msg-id E1qb7lS-001aaf-3V@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid possible overflow with ltsGetFreeBlock() in logtape.c

nFreeBlocks, defined as a long, stores the number of free blocks in a
logical tape.  ltsGetFreeBlock() has been using an int to store the
value of nFreeBlocks, which could lead to overflows on platforms where
long and int are not the same size (in short everything except Windows
where long is 4 bytes).

The problematic intermediate variable is switched to be a long instead
of an int.

Issue introduced by c02fdc9223015, so backpatch down to 13.

Author: Ranier vilela
Reviewed-by: Peter Geoghegan, David Rowley
Discussion: https://postgr.es/m/CAEudQApLDWCBR_xmwNjGBrDo+f+S4E87x3s7-+hoaKqYdtC4JQ@mail.gmail.com
Backpatch-through: 13

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d2bd4ba30585e65e57004b65106c79235aef9a44

Modified Files
--------------
src/backend/utils/sort/logtape.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: noreply@postgresql.org
Date:
Subject: pgsql: Tag refs/tags/REL_16_RC1 was created
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix comment of PQputCopyEnd()