pgsql: Meson: check for pg_config_paths.h left over from make - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Meson: check for pg_config_paths.h left over from make
Date
Msg-id E1qYwQx-000Y7c-Lc@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Meson: check for pg_config_paths.h left over from make

The meson build scripts attempt to find files left over from configure
and fail, mentioning that "make maintainer-clean" should be run to remove
these.  This seems to have been done for files generated from configure.
pg_config_paths.h is generated during the actual make build, so seems to
have been missed.  This would result in compilation using the wrong
pg_config_paths.h file.

Here we just add this file to generated_sources_ac so that meson errors
out if pg_config_paths.h exists.

Likely this wasn't noticed before because make maintainer-clean will
remove pg_config_paths.h, however, people using the MSVC build scripts
are more likely to run into issues and they have to manually remove
these files and pg_config_paths.h wasn't listed as a conflicting file to
remove in the meson log.

Backpatch-through: 16, where meson support was added
Discussion: https://postgr.es/m/CAApHDvqjYOxZfmLKAOWKFEE7LOr9_E6UA6YNmx9r8nxStcS3gg@mail.gmail.com

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5a16984ff1f3556f4bd29723e11d3594f41db90b

Modified Files
--------------
src/port/meson.build | 3 +++
1 file changed, 3 insertions(+)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Meson: check for pg_config_paths.h left over from make
Next
From: Bruce Momjian
Date:
Subject: pgsql: do: PG 16 relnotes: clarify last seq/index view names