pgsql: Fix off-by-one in XLogRecordMaxSize check. - Mailing list pgsql-committers

From Noah Misch
Subject pgsql: Fix off-by-one in XLogRecordMaxSize check.
Date
Msg-id E1qUwJY-001krt-IW@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix off-by-one in XLogRecordMaxSize check.

pg_logical_emit_message(false, '_', repeat('x', 1069547465)) failed with
self-contradictory message "WAL record would be 1069547520 bytes (of
maximum 1069547520 bytes)".  There's no particular benefit from allowing
or denying one byte in either direction; XLogRecordMaxSize could rise a
few megabytes without trouble.  Hence, this is just for cleanliness.
Back-patch to v16, where this check first appeared.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c36b636096a1aac4fd5d7c8c5d11ed2bb6349d0f

Modified Files
--------------
src/backend/access/transam/xloginsert.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Show GIDs of two-phase commit commands as constants in pg_stat_s
Next
From: Andres Freund
Date:
Subject: pgsql: ci: macos: Remove use of -DRANDOMIZE_ALLOCATED_MEMORY