pgsql: Fix leak of LLVM "fatal-on-oom" section counter. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Fix leak of LLVM "fatal-on-oom" section counter.
Date
Msg-id E1qGzqd-00212F-Gl@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix leak of LLVM "fatal-on-oom" section counter.

llvm_release_context() called llvm_enter_fatal_on_oom(), but was missing
the corresponding llvm_leave_fatal_on_oom() call. As a result, if JIT was
used at all, we were almost always in the "fatal-on-oom" state.

It only makes a difference if you use an extension written in C++, and
run out of memory in a C++ 'new' call. In that case, you would get a
PostgreSQL FATAL error, instead of the default behavior of throwing a
C++ exception.

Back-patch to all supported versions.

Reviewed-by: Daniel Gustafsson
Discussion: https://www.postgresql.org/message-id/54b78cca-bc84-dad8-4a7e-5b56f764fab5@iki.fi

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bfb493dbae7e460a7786daa7ba1522cc3eb6dac3

Modified Files
--------------
src/backend/jit/llvm/llvmjit.c | 2 ++
1 file changed, 2 insertions(+)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: pg_waldump: Add test case for notice message
Next
From: Michael Paquier
Date:
Subject: pgsql: Handle \v as a whitespace character in parsers