pgsql: Fix race in SSI interaction with empty btrees. - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Fix race in SSI interaction with empty btrees.
Date
Msg-id E1qGRa5-001lwA-HR@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix race in SSI interaction with empty btrees.

When predicate-locking btrees, we have a special case for completely
empty btrees, since there is no page to lock.  This was racy, because,
without buffer lock held, a matching key could be inserted between the
_bt_search() and the PredicateLockRelation() calls.

Fix, by rechecking _bt_search() after taking the relation-level SIREAD
lock, if using SERIALIZABLE isolation and an empty btree is discovered.

Back-patch to all supported releases.  Fixes one aspect of bug #17949.

Reported-by: Artem Anisimov <artem.anisimov.255@gmail.com>
Reviewed-by: Dmitry Dolgov <9erthalion6@gmail.com>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/17949-a0f17035294a55e2%40postgresql.org

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fe88497b4d0b0105aa4c3d3ba75ca988058a0381

Modified Files
--------------
src/backend/access/nbtree/nbtsearch.c | 39 +++++++++++++++++++++++------------
1 file changed, 26 insertions(+), 13 deletions(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Fix race in SSI interaction with bitmap heap scan.
Next
From: Thomas Munro
Date:
Subject: pgsql: Fix race in SSI interaction with bitmap heap scan.