pgsql: Fix Utils.pm's locale-munging so that Perl itself is also affect - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix Utils.pm's locale-munging so that Perl itself is also affect
Date
Msg-id E1popBP-003iLT-O7@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix Utils.pm's locale-munging so that Perl itself is also affected.

Utils.pm has a BEGIN block that editorializes on the locale-related
environment variables, primarily in order to stabilize the behavior
of child programs.  It turns out that if the calling test script
has already done "use locale", this fails to affect the behavior
of Perl itself, causing locale behavior to be different between
Perl and child programs.  That breaks commit cd82e5c79's attempt
to deal with locale-specific behavior in psql.

To fix, we just need to call setlocale() to redo the calculation
of locale.

Per report from Aleksander Alekseev.  No back-patch for now, since
there are no locale-dependent TAP tests in prior branches, and
I'm not yet convinced that this won't have side-effects of its own.

Discussion: https://postgr.es/m/CAJ7c6TO9KpYYxoVVseWEQB5KtjWDkt8NfyAeKPcHoe2Jq+ykpw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b124104e73c0e91714969e1ae24d661264c76b96

Modified Files
--------------
src/test/perl/PostgreSQL/Test/Utils.pm | 2 ++
1 file changed, 2 insertions(+)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Fix pg_basebackup with in-place tablespaces some more.
Next
From: Peter Geoghegan
Date:
Subject: pgsql: Remove useless argument from nbtree dedup function.