pgsql: Make vacuum failsafe_active globally visible - Mailing list pgsql-committers

From Daniel Gustafsson
Subject pgsql: Make vacuum failsafe_active globally visible
Date
Msg-id E1pkYdW-001kmn-27@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make vacuum failsafe_active globally visible

While vacuuming a table in failsafe mode, VacuumCostActive should
not be re-enabled.  This currently isn't a problem because vacuum
cost parameters are only refreshed in between vacuuming tables and
failsafe status is reset for every table.

In preparation for allowing vacuum cost parameters to be updated
more frequently, elevate LVRelState->failsafe_active to a global,
VacuumFailsafeActive, which will be checked when determining whether
or not to re-enable vacuum cost-related delays.

Author: Melanie Plageman <melanieplageman@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Discussion:
https://www.postgresql.org/message-id/flat/CAAKRu_ZngzqnEODc7LmS1NH04Kt6Y9huSjz5pp7%2BDXhrjDA0gw%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/71a825194fd3f8c084f63bd2b0a8d11d753d25d3

Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 16 +++++++---------
src/backend/commands/vacuum.c        | 15 +++++++++++++++
src/include/commands/vacuum.h        |  1 +
3 files changed, 23 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Stabilize just-added regression test cases.
Next
From: Andres Freund
Date:
Subject: pgsql: heapam: Pass number of required pages to RelationGetBufferForTup