pgsql: Fix inconsistent error handling for GSS encryption in PQconnectP - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Fix inconsistent error handling for GSS encryption in PQconnectP
Date
Msg-id E1pbcjx-003IIE-Ix@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix inconsistent error handling for GSS encryption in PQconnectPoll()

The error cases for TLS and GSS encryption were inconsistent.  After TLS
fails, the connection is marked as dead and follow-up calls of
PQconnectPoll() would return immediately, but GSS encryption was not
doing that, so the connection would still have been allowed to enter the
GSS handling code.  This was handled incorrectly when gssencmode was set
to "require".  "prefer" was working correctly, and this could not happen
under "disable" as GSS encryption would not be attempted.

This commit makes the error handling of GSS encryption on par with TLS
portion, fixing the case of gssencmode=require.

Reported-by: Jacob Champion
Author: Michael Paquier
Reviewed-by: Jacob Champion, Stephen Frost
Discussion: https://postgr.es/m/23787477-5fe1-a161-6d2a-e459f74c4713@timescale.com
Backpatch-through: 12

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7e319231c6bba7bad4a71a47ed0aefadf71e1103

Modified Files
--------------
src/interfaces/libpq/fe-connect.c | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: cirrus/ccache: Use G rather than GB suffix
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Improve support for UNICODE collation on older ICU