pgsql: pgstat: Track more detailed relation IO statistics - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: pgstat: Track more detailed relation IO statistics
Date
Msg-id E1pQMpw-000MPf-4r@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pgstat: Track more detailed relation IO statistics

Commit 28e626bde00 introduced the infrastructure for tracking more detailed IO
statistics. This commit adds the actual collection of the new IO statistics
for relations and temporary relations. See aforementioned commit for goals and
high-level design.

The changes in this commit are fairly straight-forward. The bulk of the change
is to passing sufficient information to the callsites of pgstat_count_io_op().

A somewhat unsightly detail is that it currently is hard to find a better
place to count fsyncs than in md.c, whereas the other pgstat_count_io_op()
calls are in bufmgr.c/localbuf.c. As the number of fsyncs is tied to md.c
implementation details, it's not obvious there is a better answer.

Author: Melanie Plageman <melanieplageman@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20200124195226.lth52iydq2n2uilq@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f30d62c2fc60acfa62d3b83a73dc9bf7f83cfe2f

Modified Files
--------------
src/backend/storage/buffer/bufmgr.c   | 110 +++++++++++++++++++++++++++++-----
src/backend/storage/buffer/freelist.c |  58 +++++++++++++-----
src/backend/storage/buffer/localbuf.c |  13 +++-
src/backend/storage/smgr/md.c         |  24 ++++++++
src/include/storage/buf_internals.h   |   8 ++-
src/include/storage/bufmgr.h          |   7 ++-
6 files changed, 184 insertions(+), 36 deletions(-)


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Fix help text spacing in pgindent
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix typo in parsenodes.h