pgsql: Fix the logical replication timeout during large DDLs. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Fix the logical replication timeout during large DDLs.
Date
Msg-id E1pPaTk-0000Zr-BZ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix the logical replication timeout during large DDLs.

The DDLs like Refresh Materialized views that generate lots of temporary
data due to rewrite rules may not be processed by output plugins (for
example pgoutput). So, we won't send keep-alive messages for a long time
while processing such commands and that can lead the subscriber side to
timeout. We have previously fixed a similar case for large transactions in
commit f95d53eded where the output plugin filters all or most of the
changes but missed to handle the DDLs.

We decided not to backpatch this as this adds a new callback in the
existing exposed structure and moreover, users can increase the
wal_sender_timeout and wal_receiver_timeout to avoid this problem.

Author: Wang wei, Hou Zhijie
Reviewed-by: Peter Smith, Ashutosh Bapat, Shi yu, Amit Kapila
Discussion: https://postgr.es/m/OS3PR01MB6275478E5D29E4A563302D3D9E2B9@OS3PR01MB6275.jpnprd01.prod.outlook.com
Discussion: https://postgr.es/m/CAA5-nLARN7-3SLU_QUxfy510pmrYK6JJb=bk3hcgemAM_pAv+w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8c58624df46222d4d09c5655d8350f3b037880c8

Modified Files
--------------
src/backend/replication/logical/logical.c       | 50 +++++++++++++++++++++++
src/backend/replication/logical/reorderbuffer.c | 20 +++++++++
src/backend/replication/pgoutput/pgoutput.c     | 54 +++----------------------
src/include/replication/reorderbuffer.h         | 12 ++++++
src/tools/pgindent/typedefs.list                |  1 +
5 files changed, 89 insertions(+), 48 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Rethink nullingrel marking rules in build_joinrel_tlist().
Next
From: David Rowley
Date:
Subject: pgsql: Remove stray duplicated comment in heapam.h