pgsql: Revert "Get rid of the "new" and "old" entries in a view's range - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Revert "Get rid of the "new" and "old" entries in a view's range
Date
Msg-id E1pFomQ-003E8j-VO@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Revert "Get rid of the "new" and "old" entries in a view's range
List pgsql-committers
Revert "Get rid of the "new" and "old" entries in a view's rangetable."

This reverts commit 1b4d280ea1eb7ddb2e16654d5fa16960bb959566.
It's broken the buildfarm members that run cross-version-upgrade tests,
because they're not prepared to deal with cosmetic differences between
CREATE VIEW commands emitted by older servers and HEAD.  Even if we had
a solution to that, which we don't, it'd take some time to roll it out
to the affected animals.  This improvement isn't valuable enough to
justify addressing that problem on an emergency basis, so revert it
for now.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f0e6d6d3c909e14eedd370dd77d7111c2ae24c02

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out   |  16 +-
src/backend/commands/lockcmds.c                  |   9 +
src/backend/commands/view.c                      | 107 ++++
src/backend/nodes/outfuncs.c                     |   7 +-
src/backend/nodes/readfuncs.c                    |   7 +-
src/backend/optimizer/plan/setrefs.c             |  26 +-
src/backend/parser/parse_relation.c              |   2 +-
src/backend/rewrite/rewriteDefine.c              |   7 +
src/backend/rewrite/rewriteHandler.c             |  38 +-
src/backend/utils/cache/plancache.c              |   3 +-
src/bin/pg_dump/t/002_pg_dump.pl                 |  12 +-
src/include/catalog/catversion.h                 |   2 +-
src/include/nodes/parsenodes.h                   |  18 +-
src/test/regress/expected/aggregates.out         |  26 +-
src/test/regress/expected/alter_table.out        |  16 +-
src/test/regress/expected/collate.icu.utf8.out   |  24 +-
src/test/regress/expected/collate.linux.utf8.out |  24 +-
src/test/regress/expected/collate.out            |  26 +-
src/test/regress/expected/compression.out        |   4 +-
src/test/regress/expected/create_view.out        | 222 +++----
src/test/regress/expected/expressions.out        |  24 +-
src/test/regress/expected/groupingsets.out       |  20 +-
src/test/regress/expected/limit.out              |  24 +-
src/test/regress/expected/matview.out            |  24 +-
src/test/regress/expected/polymorphism.out       |   8 +-
src/test/regress/expected/rangefuncs.out         |  34 +-
src/test/regress/expected/rules.out              | 748 +++++++++++------------
src/test/regress/expected/tablesample.out        |   4 +-
src/test/regress/expected/triggers.out           |   4 +-
src/test/regress/expected/updatable_views.out    |  78 +--
src/test/regress/expected/window.out             |  56 +-
src/test/regress/expected/with.out               |  32 +-
src/test/regress/expected/xml.out                |   6 +-
src/test/regress/expected/xml_2.out              |   6 +-
34 files changed, 890 insertions(+), 774 deletions(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Use WaitEventSet API for postmaster's event loop.
Next
From: Michael Paquier
Date:
Subject: pgsql: Acquire spinlock when updating 2PC slot data during logical deco