pgsql: Fix incorrect uses of Datum conversion macros - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Fix incorrect uses of Datum conversion macros
Date
Msg-id E1oVAKX-001YCT-57@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix incorrect uses of Datum conversion macros

Since these macros just cast whatever you give them to the designated
output type, and many normal uses also cast the output type further, a
number of incorrect uses go undiscovered.  The fixes in this patch
have been discovered by changing these macros to inline functions,
which is the subject of a future patch.

Reviewed-by: Aleksander Alekseev <aleksander@timescale.com>
Discussion: https://www.postgresql.org/message-id/flat/8528fb7e-0aa2-6b54-85fb-0c0886dbd6ed%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6bcda4a72123c3aa29fa3f03d952095675ad4468

Modified Files
--------------
contrib/btree_gist/btree_utils_num.c          |  2 +-
contrib/dblink/dblink.c                       |  2 +-
contrib/hstore/hstore_op.c                    |  2 +-
contrib/pageinspect/heapfuncs.c               |  4 ++--
src/backend/access/brin/brin_bloom.c          |  2 +-
src/backend/access/brin/brin_minmax_multi.c   | 12 ++++++------
src/backend/access/common/toast_compression.c |  2 +-
src/backend/access/table/toast_helper.c       |  2 +-
src/backend/access/transam/xlogfuncs.c        |  2 +-
src/backend/statistics/mcv.c                  |  4 ++--
src/backend/utils/adt/amutils.c               |  2 +-
src/backend/utils/adt/multirangetypes.c       |  2 +-
src/backend/utils/adt/pg_lsn.c                |  4 ++--
src/backend/utils/adt/pgstatfuncs.c           |  2 +-
src/backend/utils/adt/rangetypes_spgist.c     |  4 ++--
src/backend/utils/adt/regexp.c                |  2 +-
src/backend/utils/adt/tsgistidx.c             |  2 +-
src/backend/utils/adt/tsquery_op.c            |  2 +-
src/backend/utils/adt/varlena.c               |  2 +-
src/backend/utils/adt/xml.c                   |  2 +-
src/backend/utils/resowner/resowner.c         |  6 +++---
src/pl/plperl/plperl.c                        |  2 +-
22 files changed, 33 insertions(+), 33 deletions(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: Check for interrupts in pg_trgm word similarity
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Translation updates