pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix oversight in recent MULTIEXPR_SUBLINK fix.
Date
Msg-id E1oUBol-0017c0-Ii@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix oversight in recent MULTIEXPR_SUBLINK fix.

Commits 3f7323cbb et al missed the possibility that the Params
they are looking for could be buried under implicit coercions,
as well as other stuff that processIndirection() could add to
the original targetlist entry.  Copy the code in ruleutils.c
that deals with such cases.  (I thought about refactoring so
that there's just one copy; but seeing that we only need this
in old back branches, it seems not worth the trouble.)

Per off-list report from Andre Lin.  As before, only v10-v13
need the patch.

Discussion: https://postgr.es/m/17596-c5357f61427a81dc@postgresql.org

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/df92bc115ec8712cfdd0c7a26ef20b11914ab0a2

Modified Files
--------------
src/backend/optimizer/plan/subselect.c | 40 +++++++++++++++++++++++++++++++---
src/test/regress/expected/inherit.out  | 24 ++++++++++----------
src/test/regress/sql/inherit.sql       | 10 ++++-----
3 files changed, 54 insertions(+), 20 deletions(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: Remove unused code from sepgsql
Next
From: Tom Lane
Date:
Subject: pgsql: Fix planner to consider matches to boolean columns in extension