pgsql: Fix the incorrect assertion introduced in commit 7f13ac8123. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Fix the incorrect assertion introduced in commit 7f13ac8123.
Date
Msg-id E1oSUpk-000Obh-93@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix the incorrect assertion introduced in commit 7f13ac8123.

It has been incorrectly assumed in commit 7f13ac8123 that we can either
purge all or none in the catalog modifying xids list retrieved from a
serialized snapshot. It is quite possible that some of the xids in that
array are old enough to be pruned but not others.

As per buildfarm

Author: Amit Kapila and Masahiko Sawada
Reviwed-by: Masahiko Sawada
Discussion: https://postgr.es/m/CAA4eK1LBtv6ayE+TvCcPmC-xse=DVg=SmbyQD1nv_AaqcpUJEg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d2169c998553a6945fd51b8a1e5e9e1384283fdd

Modified Files
--------------
.../expected/catalog_change_snapshot.out           | 56 +++++++++++++++++++++-
.../specs/catalog_change_snapshot.spec             | 20 ++++++++
src/backend/replication/logical/snapbuild.c        | 50 +++++++++++--------
3 files changed, 106 insertions(+), 20 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Doc: fix example of recursive query.
Next
From: David Rowley
Date:
Subject: pgsql: Improve performance of and reduce overheads of memory management