pgsql: Defend against stack overrun in a few more places. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Defend against stack overrun in a few more places.
Date
Msg-id E1oQtm6-0011Jg-1I@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Defend against stack overrun in a few more places.

SplitToVariants() in the ispell code, lseg_inside_poly() in geo_ops.c,
and regex_selectivity_sub() in selectivity estimation could recurse
until stack overflow; fix by adding check_stack_depth() calls.
So could next() in the regex compiler, but that case is better fixed by
converting its tail recursion to a loop.  (We probably get better code
that way too, since next() can now be inlined into its sole caller.)

There remains a reachable stack overrun in the Turkish stemmer, but
we'll need some advice from the Snowball people about how to fix that.

Per report from Egor Chindyaskin and Alexander Lakhin.  These mistakes
are old, so back-patch to all supported branches.

Richard Guo and Tom Lane

Discussion: https://postgr.es/m/1661334672.728714027@f473.i.mail.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f25bed3801e1e500850a9f3b29a003c644d4bd6d

Modified Files
--------------
src/backend/regex/regc_lex.c         | 5 +++--
src/backend/tsearch/spell.c          | 4 ++++
src/backend/utils/adt/geo_ops.c      | 3 +++
src/backend/utils/adt/like_support.c | 4 ++++
4 files changed, 14 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Doc: remove duplicate "a" from func.sgml
Next
From: Peter Eisentraut
Date:
Subject: pgsql: pg_dump: Dump colliculocale