pgsql: Remove dead ifaddr.c fallback code. - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Remove dead ifaddr.c fallback code.
Date
Msg-id E1oOXEH-0003fb-6L@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove dead ifaddr.c fallback code.

We carried a special implementation of pg_foreach_ifaddr() using
Solaris's ioctl(SIOCGLIFCONF), but Solaris 11 and illumos adopted
getifaddrs() more than a decade ago, and we prefer to use that.  Solaris
10 is EOL'd.  Remove the dead code.

Adjust comment about which OSes have getifaddrs(), which also
incorrectly listed AIX.  AIX is in fact the only Unix in the build farm
that *doesn't* have it today, so the implementation based on
ioctl(SIOCGIFCONF) (note, no 'L') is still live.  All the others have
had it for at least one but mostly two decades.

The last-stop fallback at the bottom of the file is dead code in
practice, but it's hard to justify removing it because the better
options are all non-standard.

Discussion: https://postgr.es/m/CA+hUKGKErNfhmvb_H0UprEmp4LPzGN06yR2_0tYikjzB-2ECMw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a717cddcac518162cc17bae3c68a492db9ab2e75

Modified Files
--------------
src/backend/libpq/ifaddr.c | 112 +--------------------------------------------
1 file changed, 2 insertions(+), 110 deletions(-)


pgsql-committers by date:

Previous
From: John Naylor
Date:
Subject: pgsql: Update comment in gramparse.h
Next
From: Peter Eisentraut
Date:
Subject: Re: pgsql: Refer to replication origin roident as "ID" in user facing messa