pgsql: Fix assert in logicalmsg_desc - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Fix assert in logicalmsg_desc
Date
Msg-id E1oO4ux-0015sw-9E@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix assert in logicalmsg_desc

The assert, introduced by 9f1cf97bb5, is intended to check if the prefix
is terminated by a \0 byte, but it has two flaws. Firstly, prefix_size
includes the \0 byte, so prefix[prefix_size] points to the byte after
the null byte. Secondly, the check ensures the byte is not equal \0,
while it should be checking the opposite.

Backpatch-through: 14
Discussion: https://postgr.es/m/b99b6101-2f14-3796-3dfa-4a6cd7d4326d@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c52ad9c4efdb91ce274c65b1acdb350e439c7b2d

Modified Files
--------------
src/backend/access/rmgrdesc/logicalmsgdesc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: doc: Remove reference to tty libpq connstring param
Next
From: Tomas Vondra
Date:
Subject: pgsql: Fix assert in logicalmsg_desc