pgsql: Add missing bad-PGconn guards in libpq entry points. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Add missing bad-PGconn guards in libpq entry points.
Date
Msg-id E1oNfwq-000vTS-Ur@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add missing bad-PGconn guards in libpq entry points.

There's a convention that externally-visible libpq functions should
check for a NULL PGconn pointer, and fail gracefully instead of
crashing.  PQflush() and PQisnonblocking() didn't get that memo
though.  Also add a similar check to PQdefaultSSLKeyPassHook_OpenSSL;
while it's not clear that ordinary usage could reach that with a
null conn pointer, it's cheap enough to check, so let's be consistent.

Daniele Varrazzo and Tom Lane

Discussion: https://postgr.es/m/CA+mi_8Zm_mVVyW1iNFgyMd9Oh0Nv8-F+7Y3-BqwMgTMHuo_h2Q@mail.gmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2a280832e1d0d79bfcaf7f394d9ead6880985032

Modified Files
--------------
src/interfaces/libpq/fe-exec.c | 4 ++++
1 file changed, 4 insertions(+)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Remove redundant spaces in _outA_Expr() output
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: doc: Add unit to pg_shmem_allocations attributes