pgsql: pg_upgrade: Fix some minor code issues - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: pg_upgrade: Fix some minor code issues
Date
Msg-id E1oMczW-000VSE-B5@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_upgrade: Fix some minor code issues

96ef3b8ff1cf1950e897fd2f766d4bd9ef0d5d56 accidentally copied a not
applicable comment from the float8_pass_by_value code to the
data_checksums code.  Remove that.

87d3b35a1ca31a9d947a8f919a6006679216dff0 changed pg_upgrade to
checking the checksum version rather than just the Boolean presence of
checksums, but didn't change the field type in its ControlData struct
from bool.  So this would not work correctly if there ever is a
checksum version larger than 1.

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a47bf42d172a35622f5f764e663ea4f83d96c977

Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 1 -
src/bin/pg_upgrade/pg_upgrade.h  | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: pg_upgrade: Remove unused typedef
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Add missing fields to _outConstraint()