pgsql: Fix data-corruption hazard in WAL-logged CREATE DATABASE. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix data-corruption hazard in WAL-logged CREATE DATABASE.
Date
Msg-id E1oKM4g-000axT-Dt@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix data-corruption hazard in WAL-logged CREATE DATABASE.

RelationCopyStorageUsingBuffer thought it could skip copying
empty pages, but of course that does not work at all, because
subsequent blocks will be out of place.

Also fix it to acquire share lock on the source buffer.  It *might*
be safe to not do that, but it's not very certain, and I don't think
this code deserves any benefit of the doubt.

Dilip Kumar, per complaint from me

Discussion: https://postgr.es/m/3679800.1659654066@sss.pgh.pa.us

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/811203d4aff505c414e4a9e8c57ea6bb3edfe92e

Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Simplify gettimeofday() fallback logic.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix function-defined-but-not-used warning.