pgsql: Remove dead setenv, unsetenv replacement code. - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Remove dead setenv, unsetenv replacement code.
Date
Msg-id E1oJisY-000Kmx-0a@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove dead setenv, unsetenv replacement code.

setenv() and unsetenv() are in SUSv3 and targeted Unix systems have
them.  We still need special code for these on Windows, but that doesn't
require a configure probe.

This marks the first time we require a SUSv3 (POSIX.1-2001) facility
(rather than SUSv2).  The replacement code removed here was not needed
on any targeted system or any known non-EOL'd Unix system, and was
therefore dead and untested.

No need for vestigial HAVE_SETENV and HAVE_UNSETENV macros, because we
provide a replacement for Windows, and we didn't previously test the
macros.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Greg Stark <stark@mit.edu>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CA+hUKGJ3LHeP9w5Fgzdr4G8AnEtJ=z=p6hGDEm4qYGEUX5B6fQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/71f5dc6dfb3de50de28ddde53793540c2fa98b1f

Modified Files
--------------
configure                  | 43 ------------------------------
configure.ac               | 13 ----------
src/include/pg_config.h.in |  6 -----
src/include/port.h         |  8 ------
src/port/setenv.c          | 48 ----------------------------------
src/port/unsetenv.c        | 65 ----------------------------------------------
src/tools/msvc/Solution.pm |  2 --
7 files changed, 185 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Revert recent changes to 002_pg_upgrade.pl.
Next
From: David Rowley
Date:
Subject: pgsql: Fix failure to set correct operator in window run condition