pgsql: Add missing PGDLLEXPORT markings in contrib/pg_prewarm. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Add missing PGDLLEXPORT markings in contrib/pg_prewarm.
Date
Msg-id E1oGjSQ-001VPn-8s@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add missing PGDLLEXPORT markings in contrib/pg_prewarm.

After commit 089480c07, it's necessary for background worker entry
points to be marked PGDLLEXPORT, else they aren't findable by
LookupBackgroundWorkerFunction().  Since pg_prewarm lacks any
regression tests, it's not surprising its worker entry points were
overlooked.  (A quick search turned up no other such oversights.)

I added some documentation pointing out the need for this, too.

Robins Tharakan and Tom Lane

CAEP4nAzndnQv3-1QKb=D-hLoK3Rko12HHMFHHtdj2GQAUXO3gw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/03361a368e7bf909283cc7721af004317fdabd3d

Modified Files
--------------
contrib/pg_prewarm/autoprewarm.c |  4 ++--
doc/src/sgml/bgworker.sgml       | 11 ++++++-----
2 files changed, 8 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes.
Next
From: Robert Haas
Date:
Subject: pgsql: Convert macros to static inline functions (buf_internals.h)