pgsql: Remove Tuplesortstate.copytup function - Mailing list pgsql-committers

From Alexander Korotkov
Subject pgsql: Remove Tuplesortstate.copytup function
Date
Msg-id E1oGZbk-001RJu-Em@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove Tuplesortstate.copytup function

It's currently unclear how do we split functionality between
Tuplesortstate.copytup() function and tuplesort_put*() functions.
For instance, copytup_index() and copytup_datum() return error while
tuplesort_putindextuplevalues() and tuplesort_putdatum() do their work.
This commit removes Tuplesortstate.copytup() altogether, putting the
corresponding code into tuplesort_put*().

Discussion: https://postgr.es/m/CAPpHfdvjix0Ahx-H3Jp1M2R%2B_74P-zKnGGygx4OWr%3DbUQ8BNdw%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Pavel Borisov, Maxim Orlov, Matthias van de Meent
Reviewed-by: Andres Freund, John Naylor

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d47da3162b4d77c888c895dd36e4ef9cb92fcf19

Modified Files
--------------
src/backend/utils/sort/tuplesort.c | 331 +++++++++++++++----------------------
1 file changed, 133 insertions(+), 198 deletions(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes.
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Allow "in place" tablespaces.