pgsql: Disable unstable test cases in src/test/ssl/t/001_ssltests.pl. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Disable unstable test cases in src/test/ssl/t/001_ssltests.pl.
Date
Msg-id E1oCqF5-000Xlz-CZ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Disable unstable test cases in src/test/ssl/t/001_ssltests.pl.

Some of the test cases added by commit 3a0e38504 are failing
intermittently in CI testing.  It looks like, when a connection
attempt fails, it's possible for psql to exit and the test script
to slurp up the postmaster's log file before the connected backend
has managed to write the log entry we're expecting to see.

It's not clear whether that's fixable in any robust way.  Pending
more thought, just comment out the log_like checks.  The ones in
connect_ok tests should be fine, since surely the log entry should
be emitted before we complete the client auth sequence.  I took
out all the ones in connect_fails tests though.

Discussion: https://postgr.es/m/E1oCNLk-000LCH-Af@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/55828a6b6084724b08675615a4e911ad4d421cd1

Modified Files
--------------
src/test/ssl/t/001_ssltests.pl | 45 +++++++++++++++++++++++++-----------------
1 file changed, 27 insertions(+), 18 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Log details for client certificate failures
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Log details for client certificate failures