pgsql: Use wildcards instead of manually-maintained file lists in */nls - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Use wildcards instead of manually-maintained file lists in */nls
Date
Msg-id E1oBfff-002eRi-Sq@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Use wildcards instead of manually-maintained file lists in */nls.mk.

The backend already used a mechanically-generated list of *.c files,
but everywhere else we had a manually-written-out list of files in
which to seek translatable messages.  Commit b0a55e432 contains the
latest in a long line of failures to update those lists.  Rather than
manually fix its oversight, let's change to using "$(wildcard *.c)"
in all these nls.mk files.

Many of these files also have manual references to some *.c files
in other directories, most often src/common/.  Perhaps we should try
to improve that situation too; but it's a bit less clear how, so for
now just fix the local file references.

Kyotaro Horiguchi and Tom Lane

Discussion: https://postgr.es/m/20220713.160853.453362706160476128.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/617d69141220f277170927e03a19d2f1b77aed77

Modified Files
--------------
src/bin/initdb/nls.mk              |  2 +-
src/bin/pg_amcheck/nls.mk          |  3 +--
src/bin/pg_archivecleanup/nls.mk   |  2 +-
src/bin/pg_basebackup/nls.mk       | 14 +-------------
src/bin/pg_checksums/nls.mk        |  3 +--
src/bin/pg_config/nls.mk           |  2 +-
src/bin/pg_controldata/nls.mk      |  2 +-
src/bin/pg_ctl/nls.mk              |  2 +-
src/bin/pg_dump/nls.mk             |  8 +-------
src/bin/pg_resetwal/nls.mk         |  2 +-
src/bin/pg_rewind/nls.mk           |  2 +-
src/bin/pg_test_fsync/nls.mk       |  2 +-
src/bin/pg_test_timing/nls.mk      |  2 +-
src/bin/pg_upgrade/nls.mk          |  4 +---
src/bin/pg_verifybackup/nls.mk     |  4 +---
src/bin/pg_waldump/nls.mk          |  2 +-
src/bin/psql/nls.mk                |  6 +-----
src/bin/scripts/nls.mk             |  7 +------
src/interfaces/ecpg/ecpglib/nls.mk |  2 +-
src/interfaces/ecpg/preproc/nls.mk |  2 +-
src/interfaces/libpq/nls.mk        |  2 +-
src/pl/plperl/nls.mk               |  2 +-
src/pl/plpgsql/src/nls.mk          |  2 +-
src/pl/plpython/nls.mk             |  3 +--
src/pl/tcl/nls.mk                  |  2 +-
25 files changed, 25 insertions(+), 59 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Remove artificial restrictions on which node types have out/read
Next
From: Tom Lane
Date:
Subject: pgsql: Avoid unsatisfied-external-reference errors in static inlines.