pgsql: pgstat: drop subscription stats without slot as well, fix commen - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: pgstat: drop subscription stats without slot as well, fix commen
Date
Msg-id E1o97sj-001VPA-P8@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pgstat: drop subscription stats without slot as well, fix comment

There's no reason anymore to only drop subscription stats if associated with a
slot, now that stats drops are transactional. And since there's now no other
cleanup of stats, this would lead to stats for slot-less subscriptions to get
leaked (however most slot-less subs won't have stats).

Additionally, the comment referring to autovacuum cleaning up stats was
clearly outdated.

Author: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://postgr.es/m/CAD21AoAwiby3HeJE7vJe16Gr75RFfJ640dyHqvsiUhyKJTXPtw@mail.gmail.com
Backpatch: 15-

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7b64e4b3fa04769b725306a75bf3dd26e5a854fa

Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Change internal RelFileNode references to RelFileNumber or RelFi
Next
From: Robert Haas
Date:
Subject: pgsql: pg_stat_statements: Fix test that assumes wal_records = rows.