pgsql: Don't fail on libpq-generated error reports in pg_amcheck. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Don't fail on libpq-generated error reports in pg_amcheck.
Date
Msg-id E1nyEdH-00308s-3k@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't fail on libpq-generated error reports in pg_amcheck.

An error PGresult generated by libpq itself, such as a report of
connection loss, won't have broken-down error fields.
should_processing_continue() blithely assumed that
PG_DIAG_SEVERITY_NONLOCALIZED would always be present, and would
dump core if it wasn't.

Per grepping to see if 6d157e7cb's mistake was repeated elsewhere.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/51da231597a9e414174cf621b219559e18269dc3

Modified Files
--------------
src/bin/pg_amcheck/pg_amcheck.c | 2 ++
1 file changed, 2 insertions(+)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Don't fail on libpq-generated error reports in ecpg_raise_backen
Next
From: Tom Lane
Date:
Subject: pgsql: Fix off-by-one loop termination condition in pg_stat_get_subscri