pgsql: Fix breakage in AlterFunction(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix breakage in AlterFunction().
Date
Msg-id E1nh0dc-000CXm-Id@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix breakage in AlterFunction().

An ALTER FUNCTION command that tried to update both the function's
proparallel property and its proconfig list failed to do the former,
because it stored the new proparallel value into a tuple that was
no longer the interesting one.  Carelessness in 7aea8e4f2.

(I did not bother with a regression test, because the only likely
future breakage would be for someone to ignore the comment I added
and add some other field update after the heap_modify_tuple step.
A test using existing function properties could not catch that.)

Per report from Bryn Llewellyn.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/8AC9A37F-99BD-446F-A2F7-B89AD0022774@yugabyte.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/409bcfda6bd62479f4f7e745c4a536757dbe9637

Modified Files
--------------
src/backend/commands/functioncmds.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix breakage in AlterFunction().
Next
From: David Rowley
Date:
Subject: pgsql: Doc: use "an SQL" consistently rather than "a SQL"