pgsql: Revert "Logical decoding of sequences" - Mailing list pgsql-committers

Revert "Logical decoding of sequences"

This reverts a sequence of commits, implementing features related to
logical decoding and replication of sequences:

 - 0da92dc530c9251735fc70b20cd004d9630a1266
 - 80901b32913ffa59bf157a4d88284b2b3a7511d9
 - b779d7d8fdae088d70da5ed9fcd8205035676df3
 - d5ed9da41d96988d905b49bebb273a9b2d6e2915
 - a180c2b34de0989269fdb819bff241a249bf5380
 - 75b1521dae1ff1fde17fda2e30e591f2e5d64b6a
 - 2d2232933b02d9396113662e44dca5f120d6830e
 - 002c9dd97a0c874fd1693a570383e2dd38cd40d5
 - 05843b1aa49df2ecc9b97c693b755bd1b6f856a9

The implementation has issues, mostly due to combining transactional and
non-transactional behavior of sequences. It's not clear how this could
be fixed, but it'll require reworking significant part of the patch.

Discussion: https://postgr.es/m/95345a19-d508-63d1-860a-f5c2f41e8d40@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2c7ea57e56ca5f668c32d4266e0a3e45b455bef5

Modified Files
--------------
contrib/test_decoding/Makefile                     |    3 +-
contrib/test_decoding/expected/ddl.out             |   38 +-
.../test_decoding/expected/decoding_in_xact.out    |    4 +-
.../test_decoding/expected/decoding_into_rel.out   |   10 +-
contrib/test_decoding/expected/mxact.out           |    8 +-
contrib/test_decoding/expected/ondisk_startup.out  |    4 +-
contrib/test_decoding/expected/replorigin.out      |   12 +-
contrib/test_decoding/expected/rewrite.out         |    6 +-
contrib/test_decoding/expected/sequence.out        |  325 ------
contrib/test_decoding/expected/slot.out            |    8 +-
contrib/test_decoding/expected/toast.out           |   10 +-
contrib/test_decoding/expected/truncate.out        |    2 +-
contrib/test_decoding/specs/mxact.spec             |    2 +-
contrib/test_decoding/specs/ondisk_startup.spec    |    2 +-
contrib/test_decoding/sql/ddl.sql                  |   38 +-
contrib/test_decoding/sql/decoding_in_xact.sql     |    4 +-
contrib/test_decoding/sql/decoding_into_rel.sql    |   10 +-
contrib/test_decoding/sql/replorigin.sql           |   12 +-
contrib/test_decoding/sql/rewrite.sql              |    6 +-
contrib/test_decoding/sql/sequence.sql             |  119 ---
contrib/test_decoding/sql/slot.sql                 |    8 +-
contrib/test_decoding/sql/toast.sql                |   10 +-
contrib/test_decoding/sql/truncate.sql             |    2 +-
contrib/test_decoding/test_decoding.c              |   87 --
doc/src/sgml/catalogs.sgml                         |   81 --
doc/src/sgml/logicaldecoding.sgml                  |   65 +-
doc/src/sgml/protocol.sgml                         |  119 ---
doc/src/sgml/ref/alter_publication.sgml            |   25 +-
doc/src/sgml/ref/alter_subscription.sgml           |    8 +-
doc/src/sgml/ref/create_publication.sgml           |   51 +-
src/backend/catalog/objectaddress.c                |   44 +-
src/backend/catalog/pg_publication.c               |  328 +-----
src/backend/catalog/system_views.sql               |   10 -
src/backend/commands/publicationcmds.c             |  435 ++------
src/backend/commands/sequence.c                    |  186 ----
src/backend/commands/subscriptioncmds.c            |  101 +-
src/backend/commands/tablecmds.c                   |   27 +-
src/backend/executor/execReplication.c             |    4 +-
src/backend/nodes/copyfuncs.c                      |    4 +-
src/backend/nodes/equalfuncs.c                     |    4 +-
src/backend/parser/gram.y                          |   79 +-
src/backend/replication/logical/decode.c           |  131 ---
src/backend/replication/logical/logical.c          |   88 --
src/backend/replication/logical/proto.c            |   52 -
src/backend/replication/logical/reorderbuffer.c    |  405 --------
src/backend/replication/logical/tablesync.c        |  109 +-
src/backend/replication/logical/worker.c           |   56 --
src/backend/replication/pgoutput/pgoutput.c        |   94 +-
src/backend/utils/cache/relcache.c                 |   28 +-
src/backend/utils/cache/syscache.c                 |    6 +-
src/bin/pg_dump/pg_dump.c                          |   64 +-
src/bin/pg_dump/pg_dump.h                          |    3 -
src/bin/pg_dump/t/002_pg_dump.pl                   |   40 +-
src/bin/psql/describe.c                            |  297 ++----
src/bin/psql/tab-complete.c                        |   36 +-
src/include/access/rmgrlist.h                      |    2 +-
src/include/catalog/catversion.h                   |    2 +-
src/include/catalog/pg_proc.dat                    |    5 -
src/include/catalog/pg_publication.h               |   27 +-
src/include/catalog/pg_publication_namespace.h     |   10 +-
src/include/commands/sequence.h                    |    2 -
src/include/nodes/parsenodes.h                     |    8 +-
src/include/replication/decode.h                   |    1 -
src/include/replication/logicalproto.h             |   19 -
src/include/replication/output_plugin.h            |   27 -
src/include/replication/pgoutput.h                 |    1 -
src/include/replication/reorderbuffer.h            |   43 +-
src/test/regress/expected/object_address.out       |   10 +-
src/test/regress/expected/publication.out          | 1043 ++++----------------
src/test/regress/expected/rules.out                |    8 -
src/test/regress/sql/object_address.sql            |    5 +-
src/test/regress/sql/publication.sql               |  242 +----
src/test/subscription/t/030_sequences.pl           |  202 ----
73 files changed, 605 insertions(+), 4762 deletions(-)