pgsql: Change fastgetattr and heap_getattr to inline functions - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Change fastgetattr and heap_getattr to inline functions
Date
Msg-id E1nXQrj-001C9h-8Y@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Change fastgetattr and heap_getattr to inline functions  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Change fastgetattr and heap_getattr to inline functions

They were macros previously, but recent callsite additions made Coverity
complain about one of the assertions being always true.  This change
could have been made a long time ago, but the Coverity complain broke
the inertia.

Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Japin Li <japinli@hotmail.com>
Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Discussion: https://postgr.es/m/202203241021.uts52sczx3al@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e27f4ee0a701854daf16ac1d044f20d28a17053e

Modified Files
--------------
src/backend/access/heap/heapam.c  |  46 ------------
src/include/access/htup_details.h | 151 +++++++++++++++++---------------------
2 files changed, 69 insertions(+), 128 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Invent recursive_worktable_factor GUC to replace hard-wired cons
Next
From: Tom Lane
Date:
Subject: pgsql: Doc: add some documentation about serialization failure handling