pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test
Date
Msg-id E1nX5gU-0013cw-Vw@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test
List pgsql-committers
pg_upgrade: Upgrade an Assert to a real 'if' test

It seems possible for the condition being tested to be true in
production, and nobody would never know (except when some data
eventually becomes corrupt?).

Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m//202109040001.zky3wgv2qeqg@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3e1c942a4e2f06e9b0196180eb8fd1383e6d788e

Modified Files
--------------
src/bin/pg_rewind/parsexlog.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: pg_basebackup: Try to fix some failures on Windows.
Next
From: Alvaro Herrera
Date:
Subject: Re: pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test