pgsql: vacuumlazy.c: Remove obsolete num_tuples field. - Mailing list pgsql-committers

From Peter Geoghegan
Subject pgsql: vacuumlazy.c: Remove obsolete num_tuples field.
Date
Msg-id E1nNQsM-000Fho-LI@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
vacuumlazy.c: Remove obsolete num_tuples field.

Commit 49c9d9fc unified VACUUM VERBOSE and autovacuum logging.  It
neglected to remove an old vacrel field that was only used by the old
VACUUM VERBOSE, so remove it now.

The previous num_tuples approach doesn't seem to have any real advantage
over the approach VACUUM VERBOSE takes now (also the approach used by
the autovacuum logging code), which is to show new_rel_tuples.
new_rel_tuples is the possibly-estimated total number of tuples left in
the table, whereas num_tuples meant the number of tuples encountered
during the VACUUM operation, after pruning, without regard for tuples
from pages skipped via the visibility map.

In passing, reorder a related vacrel field for consistency.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/73c61a50a1555007001d29844dcdb10b4f982a73

Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 27 ++++++++-------------------
1 file changed, 8 insertions(+), 19 deletions(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Fix few values in pg_proc for pg_stat_get_replication_slot.
Next
From: Andres Freund
Date:
Subject: pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL