pgsql: Fix data loss on crash after sorted GiST index build. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Fix data loss on crash after sorted GiST index build.
Date
Msg-id E1nNFAq-000Aa1-Lq@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix data loss on crash after sorted GiST index build.

If a checkpoint happens during the index build, and the system crashes
after the checkpoint and the index build have finished, the data written
to the index before the checkpoint started could be lost. The checkpoint
won't have fsync'd it, and it won't be replayed at crash recovery either.
Fix by calling smgrimmedsync() after the index build, just like in B-tree
index build.

Backpatch to v14 where the sorted GiST index build was introduced.

Reported-by: Melanie Plageman
Discussion: https://www.postgresql.org/message-id/CAAKRu_ZJJynimxKj5xYBSziL62-iEtPE+fx-B=JzR=jUtP92mw@mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7d80e93fb1f1059ba3691b2584bb16992d7d734e

Modified Files
--------------
src/backend/access/gist/gistbuild.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Simplify more checks related to set-returning functions
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: Guard against reallocation failure in pg_regress