pgsql: Revert "Add TAP test to automate the equivalent of check_guc" - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Revert "Add TAP test to automate the equivalent of check_guc"
Date
Msg-id E1nIjge-00029c-Lt@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Revert "Add TAP test to automate the equivalent of check_guc"

This reverts commit b0a55f4, to remove for now the TAP test that did the
equivalent of check_guc.  The test has been using pg_config --sharedir
to find the location of postgresql.conf.sample.  While the buildfarm and
normal build environments rather liked that, this proves to be an issue
for Debian where pg_config is patched to not be relocatable, causing the
test to fail.

Rather than relying on pg_config, we'd better find the sample file based
on its location from the source directory.  However, this is also an
issue as a TAP test only offers the build directory as of TESTDIR in the
environment context, so this would fail with VPATH builds.  Perhaps the
source path could be provided additionally when running the TAP tests.
Or perhaps we may be able to get away by just switching to a SQL
approach, by using PG_ABS_SRCDIR but this is going to require some extra
loops to get the sample file from the correct path in src/backend/.  In
any case, this needs more thoughts, so just revert the test case until
something better is done about this relocation problem.

Reported-by: Christopher Berg
Discussion: https://postgr.es/m/YgYw25OXV5men8Fj@msg.df7cb.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/52377bb81a2c0427d357bba71e7149de02d016ce

Modified Files
--------------
src/test/modules/test_misc/t/003_check_guc.pl | 110 --------------------------
1 file changed, 110 deletions(-)


pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Consolidate VACUUM xid cutoff logic.
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression.