pgAdmin 4 commit: Fixed following code smells reported by SonarQube: - Mailing list pgadmin-hackers

Fixed following code smells reported by SonarQube:
 1) Remove this redundant jump.
 2) Remove this commented out code.
 3) Variables should not be shadowed.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=343c3ee49c8a4e252d0a5a22d59e85325836af1f

Modified Files
--------------
.../foreign_tables/static/js/foreign_table.ui.js   | 11 +++---
.../schemas/sequences/static/js/sequence.ui.js     |  1 -
.../schemas/tables/indexes/static/js/index.ui.js   |  4 +--
.../databases/schemas/tables/static/js/table.ui.js | 15 ++++----
.../databases/schemas/types/static/js/type.js      |  1 -
.../databases/schemas/types/static/js/type.ui.js   | 10 +++---
.../databases/schemas/views/static/js/mview.js     |  1 -
.../servers/databases/static/js/database.js        |  4 +--
.../server_groups/servers/roles/static/js/role.js  | 30 ++++++++--------
.../server_groups/servers/static/js/server.js      |  1 -
web/pgadmin/browser/static/js/browser.js           |  2 +-
web/pgadmin/browser/static/js/dialog.js            |  5 ++-
web/pgadmin/browser/static/js/keyboard.js          |  1 -
web/pgadmin/browser/static/js/node_view.jsx        | 10 +++---
web/pgadmin/browser/static/js/preferences.js       |  2 --
web/pgadmin/misc/bgprocess/static/js/bgprocess.js  |  2 --
.../misc/file_manager/static/js/select_dialogue.js |  4 +--
web/pgadmin/misc/file_manager/static/js/utility.js |  4 ---
web/pgadmin/preferences/static/js/preferences.js   |  4 +--
web/pgadmin/static/js/SchemaView/DataGridView.jsx  |  9 ++---
web/pgadmin/static/js/SchemaView/FieldSetView.jsx  |  4 +--
web/pgadmin/static/js/SchemaView/FormView.jsx      |  4 +--
web/pgadmin/static/js/SchemaView/MappedControl.jsx | 16 ++++-----
web/pgadmin/static/js/components/CheckBoxTree.jsx  |  4 +--
web/pgadmin/static/js/components/PgTable.jsx       |  4 +--
web/pgadmin/static/js/slickgrid/editors.js         |  1 -
web/pgadmin/static/js/sqleditor/filter_dialog.js   |  1 -
web/pgadmin/static/js/sqleditor/macro.js           |  1 -
.../static/js/sqleditor/new_connection_dialog.js   |  5 ++-
.../static/js/sqleditor/query_tool_actions.js      |  1 -
web/pgadmin/static/vendor/require/require.js       | 42 +++++++++++-----------
web/pgadmin/tools/backup/static/js/backup.ui.js    | 14 ++++----
.../tools/backup/static/js/backupGlobal.ui.js      |  4 +--
web/pgadmin/tools/debugger/static/js/debugger.js   |  4 +--
.../tools/erd/static/js/erd_tool/ERDCore.js        |  4 +--
.../tools/grant_wizard/static/js/GrantWizard.jsx   |  8 ++---
.../tools/import_export/static/js/import_export.js |  2 --
.../static/js/ImportExportServers.jsx              |  4 +--
.../tools/maintenance/static/js/maintenance.js     |  4 +--
.../tools/maintenance/static/js/maintenance.ui.js  |  4 +--
web/pgadmin/tools/psql/static/js/psql_module.js    | 14 ++++----
web/pgadmin/tools/restore/static/js/restore.ui.js  | 14 ++++----
.../tools/schema_diff/static/js/schema_diff_ui.js  |  2 +-
.../javascript/browser/preferences_spec.js         |  1 -
.../import_export_servers.ui.spec.js               |  2 +-
.../javascript/schema_ui_files/index.ui.spec.js    |  2 +-
.../schema_ui_files/row_security_policy.ui.spec.js |  1 -
.../javascript/schema_ui_files/trigger.ui.spec.js  |  1 -
.../javascript/sqleditor/execute_query_spec.js     |  1 -
.../sqleditor/query_tool_actions_spec.js           |  1 -
50 files changed, 130 insertions(+), 161 deletions(-)