pgsql: Fix TestLib::slurp_file() with offset on windows. - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Fix TestLib::slurp_file() with offset on windows.
Date
Msg-id E1mXUtZ-0007M8-Ga@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix TestLib::slurp_file() with offset on windows.

3c5b0685b921 used setFilePointer() to set the position of the filehandle, but
passed the wrong filehandle, always leaving the position at 0. Instead of just
fixing that, remove use of setFilePointer(), we have a perl fd at this point,
so we can just use perl's seek().

Additionally, the perl filehandle wasn't closed, just the windows filehandle.

Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de
Backpatch: 9.6-, like 3c5b0685b921

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2f74db1236fe83e6665e5b0ddad4454c69495614

Modified Files
--------------
src/test/perl/TestLib.pm | 36 ++++++++++++++++++------------------
1 file changed, 18 insertions(+), 18 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.
Next
From: Andres Freund
Date:
Subject: pgsql: Fix TestLib::slurp_file() with offset on windows.